Landing page polish: sign-in error modal, theme toggle visibility, copy & accessibility pass - #223
Conversation
…sign-in error handling
…rove text styling in ProfileSettingsPage
|
Warning Review limit reached
Next review available in: 51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request adds an accessible sign-in error modal, expands theme-toggle visibility, adjusts timeline and landing-page layouts, reduces the hero demo size, and revises localization, metadata, and interface copy. ChangesUI, Authentication, and Content
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant UserMenu
participant SignInErrorModal
participant TranslationCatalog
User->>UserMenu: starts Google sign-in
UserMenu->>UserMenu: records sign-in failure
UserMenu->>SignInErrorModal: renders unavailable state
SignInErrorModal->>TranslationCatalog: loads translated title and message
User->>SignInErrorModal: closes with button, backdrop, or Escape
SignInErrorModal->>UserMenu: invokes onClose
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Preview for Bayan Flow Staging ready!
Preview alias |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/SignInErrorModal.jsx`:
- Around line 57-61: Update the modal keyboard handling around the dialog
element in SignInErrorModal so Tab and Shift+Tab cannot move focus outside the
open modal; since it has one control, retain focus on the close button, and add
a test covering both Tab directions while preserving Escape-to-close behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a12a004b-c8ab-428f-815a-85e2cf9ea7c7
📒 Files selected for processing (20)
.impeccable/design.jsonpublic/.well-known/mcp.jsonpublic/.well-known/mcp/server-card.jsonsrc/components/AlgorithmNotesTab.test.jsxsrc/components/ControlPanel.jsxsrc/components/Header.jsxsrc/components/SignInErrorModal.jsxsrc/components/SignInErrorModal.test.jsxsrc/components/UserMenu.jsxsrc/components/UserMenu.test.jsxsrc/components/landing/AlgorithmTypes.test.jsxsrc/components/landing/Hero.jsxsrc/components/landing/HeroVisualizerDemo.jsxsrc/components/landing/HeroVisualizerDemo.test.jsxsrc/components/landing/heroVisualizerDemoConfig.jssrc/i18n/locales/ar/translation.jsonsrc/i18n/locales/en/translation.jsonsrc/i18n/locales/fr/translation.jsonsrc/index.csssrc/pages/ProfileSettingsPage.jsx
1 participant
Contribution workflow
develop: This PR targetsdevelop, notmain.Description
Polish pass on the landing page and header/sign-in UX: failed Google sign-ins now surface in a proper accessible dialog instead of inline text, the theme toggle is available on more pages, and a sweep of copy revisions improve clarity and accessibility across locales (em dashes replaced with periods/pipes, more natural sentence flow). Also fixes the ControlPanel seek thumb overflow, hero demo layout on small screens, and a low-contrast hint in profile settings.
Type of Change
Related Issues
Fixes #
Changes Made
SignInErrorModal(focus management, Escape/backdrop close, reduced-motion aware) and wire it intoUserMenufor both navbar and landing variants, replacing the inline error textaccessBan.signInUnavailableTitlei18n key in en/fr/ar and compact navbar proportions for the sign-in button (data-navbar-signin+ CSS)ControlPanelseek thumb so it stays inside the track (RTL-aware)ThemeToggleon/app,/settings,/roadmap, and/pro(was app-only)max-w-fullstage so bars don't overflow; demo array reduced 6 → 5server-card/mcp.jsondescriptions,.impeccable/design.json, and algorithm insight + step descriptions for clearer, more accessible phrasingAlgorithmTypes,AlgorithmNotesTab) to match the revised copy; addSignInErrorModalunit tests (7) and extendUserMenutestsAlgorithm Details (if applicable)
N/A — no algorithms added or changed.
Testing
pnpm test:run)Test Results
Screenshots/GIFs
SignInErrorModaldialog shown on sign-in failureCode Quality
pnpm lint)pnpm format)Performance Impact
Accessibility
role="dialog",aria-modal, labelled heading)Breaking Changes
Checklist
Additional Notes
Local gate run before push:
pnpm lint(0 errors),pnpm format:check(clean),pnpm test:coverage(2010 passed),pnpm build(success).Summary by CodeRabbit
New Features
Bug Fixes