Open
Conversation
Collaborator
Author
|
We should wait to this PR to be approved |
Collaborator
Author
|
We should wait for this changes to be released #3608 |
Owner
|
@pxp9 looking great. can you please fix clippy? |
pxp9
changed the title
ayrat555
reviewed
Dec 22, 2024
| # "sqlite", | ||
| # "mysql", | ||
| #] } | ||
| sqlx = { git = "https://github.com/launchbadge/sqlx.git", branch = "main", features = [ |
Owner
There was a problem hiding this comment.
it won't be possible to release a new version if the crate will reference a github repo
Collaborator
Author
There was a problem hiding this comment.
I know , I am officially waiting for the sqlx 8.3 release.
Collaborator
Author
There was a problem hiding this comment.
hey thank you @aidant , I will work on this , this afternoon.
ayrat555
approved these changes
Dec 22, 2024
aidant
reviewed
Jan 27, 2025
| # "sqlite", | ||
| # "mysql", | ||
| #] } | ||
| sqlx = { git = "https://github.com/launchbadge/sqlx.git", branch = "main", features = [ |
Comment on lines
+1
to
+6
| [toolchain] | ||
| versioned = "1.83" | ||
| channel = "stable-x86_64-unknown-linux-gnu" | ||
| components = ["rustfmt", "rustc-dev", "clippy"] | ||
| targets = ["x86_64-unknown-linux-gnu"] | ||
| profile = "minimal" |
There was a problem hiding this comment.
You probably don't want to limit the toolchain to x86_64-unknown-linux-gnu since it would prevent target triples like aarch64-apple-darwin
Suggested change
| [toolchain] | |
| versioned = "1.83" | |
| channel = "stable-x86_64-unknown-linux-gnu" | |
| components = ["rustfmt", "rustc-dev", "clippy"] | |
| targets = ["x86_64-unknown-linux-gnu"] | |
| profile = "minimal" | |
| [toolchain] | |
| versioned = "1.83" | |
| channel = "stable" | |
| components = ["rustfmt", "rustc-dev", "clippy"] | |
| profile = "minimal" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the crate sqlx.