libcamera: fix compilation errors for libcamera v0.3.2+rpt20241119 #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Gehrsitz <[email protected]>
This adds a runtime error for missing ControlTypes to fix compilation errors if there are new ControlTypes that are not implemented yet. Signed-off-by: Patrick Gehrsitz <[email protected]>
Signed-off-by: Patrick Gehrsitz <[email protected]>
Signed-off-by: Patrick Gehrsitz <[email protected]>
Signed-off-by: Patrick Gehrsitz <[email protected]>
Signed-off-by: Patrick Gehrsitz <[email protected]>
This was referenced Dec 7, 2024
|
any making an updated release, I miss camera-streamer :(. Good work @mryel00 |
Contributor
Author
|
Closing this for #168 separating the changes into a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
This PR adds a default case to throw an error during runtime instead of compilation, if a
ControlTypeis not implemented yet.This also adds parsing for the new
ControlTypePointadded with libcamera v0.3.2+rpt20241119.This might break compilation for libcamera v0.3.2+rpt20240927 and v0.3.2+rpt20241119.