fix: set cors for every response #194
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing CORS header can result in wrong errors on the client application, if the client is not on the same host as the server. An example setup would be Mainsail hosted locally for testing and camera-streamer hosted on a Pi.
On the screenshot you can see a 500 status code thrown by an unavailable STUN server. Someone should expect a response with status code 500 and a body containing
Not completefrom the server. Instead you get aTypeErrorin the client, as the response could not get fetched because of the missing CORS header.Adding CORS to each response should not be harmful and allows the processing of the whole response, even if the request was not successful.