Read params from src/config.h. Precedence given to platformio config. #204
Conversation
|
This PR is marked as stale because it has been open 45 days with no activity. You can remove stale label or comment if this PR is still valid. |
|
Happy to take suggestions on how to improve this PR. Please advise! |
|
This PR is marked as stale because it has been open 45 days with no activity. You can remove stale label or comment if this PR is still valid. |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
This PR is marked as stale because it has been open 45 days with no activity. You can remove stale label or comment if this PR is still valid. |
ayushsharma82
force-pushed
the
master
branch
3 times, most recently
from
4e24f8a to
7e03523
Compare
|
This PR is marked as stale because it has been open 45 days with no activity. You can remove stale label or comment if this PR is still valid. |
1 participant
Many projects use src/config.h to define hostname, username, and password constants in C++ outside of version control using .gitignore. Not sure if it's in fitting with this project's aesthetic to be (admittedly) hackishly pulling from src/config.h if it exists, but this is a huge convenience and makes it easier to keep credentials in a single, secure place. Happy to take suggestions on improvements.