refactor(sort-imports): use computeGroup instead of useGroups#506
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 96 95 -1
Lines 7651 7665 +14
Branches 1578 1572 -6
=========================================
+ Hits 7651 7665 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hugop95
force-pushed
the
refactor/sort-imports
branch
4 times, most recently
from
e7dd04d to
2efcca6
Compare
- Those options are the same as the default ones. - Linting in next commit.
hugop95
force-pushed
the
refactor/sort-imports
branch
from
2efcca6 to
0ea3c6e
Compare
azat-io
approved these changes
Apr 8, 2025
Owner
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
computeGroupfunction #500.Description
In this PR, we are finally removing
useGroupsin favor ofcomputeGroup. Additionally, we are simplifying options in tests to lighten the total number of lines of code.No actual test input/output changed.
What is the purpose of this pull request?