Skip to content

feat(sort-imports): update default groups to new API#511

Merged
azat-io merged 4 commits into
azat-io:mainfrom
hugop95:feat/sort-imports/default-groups
Apr 19, 2025
Merged

feat(sort-imports): update default groups to new API#511
azat-io merged 4 commits into
azat-io:mainfrom
hugop95:feat/sort-imports/default-groups

Conversation

@hugop95
Copy link
Copy Markdown
Contributor

@hugop95 hugop95 commented Apr 12, 2025

Description

This PR adds a value modifier alongside an import selector in order for the groups option not to rely on deprecated selectors.

import selector

This selector has the lowest priority of all selectors and will match every import.

value modifier

Similar to the type modifier. Any non-type import will have the value modifier, even side-effect imports.

Tests impacted

No input/output impact. Only error messages had to be updated.

What is the purpose of this pull request?

  • New Feature

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aeb0322) to head (59e05c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #511   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         7857      7855    -2     
  Branches      1576      1577    +1     
=========================================
- Hits          7857      7855    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hugop95 hugop95 force-pushed the feat/sort-imports/default-groups branch 5 times, most recently from b7abbe2 to 09e37c2 Compare April 12, 2025 13:22
@hugop95 hugop95 force-pushed the feat/sort-imports/default-groups branch 6 times, most recently from 7108335 to 4bbbbfa Compare April 19, 2025 11:02
@azat-io azat-io changed the title feat(sort-imports) update default groups to new API feat(sort-imports): update default groups to new API Apr 19, 2025
@hugop95 hugop95 force-pushed the feat/sort-imports/default-groups branch from 4bbbbfa to 59e05c5 Compare April 19, 2025 15:12
@hugop95 hugop95 marked this pull request as ready for review April 19, 2025 15:14
@azat-io
Copy link
Copy Markdown
Owner

azat-io commented Apr 19, 2025

Awesome!

@azat-io azat-io merged commit c76c28a into azat-io:main Apr 19, 2025
10 checks passed
@hugop95 hugop95 deleted the feat/sort-imports/default-groups branch April 19, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants