Skip to content

Fix typos#88

Merged
azat merged 1 commit intoazat:mainfrom
myfloss:fix-typos
Apr 18, 2025
Merged

Fix typos#88
azat merged 1 commit intoazat:mainfrom
myfloss:fix-typos

Conversation

@kianmeng
Copy link
Contributor

Found via typos --hidden --format brief

Found via `typos --hidden --format brief`
Copy link
Owner

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can we add this to CI to avoid such errors in future?

@azat azat merged commit b72c8bd into azat:main Apr 18, 2025
7 checks passed
*new_end -= Duration::try_minutes(minutes).unwrap();
log::debug!(
"Set time frame to ({}, {}) (seeked to {} minutes backward)",
"Set time frame to ({}, {}) (sought to {} minutes backward)",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong

*new_end += Duration::try_minutes(minutes).unwrap();
log::debug!(
"Set time frame to ({}, {}) (seeked to {} minutes backward)",
"Set time frame to ({}, {}) (sought to {} minutes backward)",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as this

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is, but sounds odd/old fashion - 23b3706

@kianmeng
Copy link
Contributor Author

Can we add this to CI to avoid such errors in future?

Added here, #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants