Skip to content

Add remaining spanish and mandarin translations#822

Merged
simonkassel merged 3 commits into
developfrom
sk/translations
May 1, 2026
Merged

Add remaining spanish and mandarin translations#822
simonkassel merged 3 commits into
developfrom
sk/translations

Conversation

@simonkassel

@simonkassel simonkassel commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

Overview

Adds the rest of the spanish and mandarin translations that where not covered by #807

The source for the translations are here:

Checklist

  • fixup! commits have been squashed
  • CHANGELOG.md updated with summary of features or fixes, following
    Keep a Changelog guidelines
  • README.md updated if necessary to reflect the changes
  • Run ./scripts/format to lint, format, and fix the application source code.
  • CI passes after rebase

Demo

english
image

spanish
image

chinese
image

Testing Instructions

  • I already pushed these changes up to a test branch so you just need to go onto staging and check to make sure that the translations have been applied.
  • Toggle the language in the top right
  • There are many places to check but one is on the discover page, click on any neighborhood in your top 10, then in the resulting modal, scroll down to "your trips" then click on "edit your trips" and ensure that all of the text in the resulting modal is in the appropriate language

Resolves #809

@simonkassel simonkassel requested a review from rajadain April 30, 2026 18:57
@simonkassel simonkassel marked this pull request as ready for review April 30, 2026 18:57

@rajadain rajadain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Chinese translation file is missing translations for Favorites and Favorite Neighborhoods, which are specified in the Chinese translations Google Doc. Other than that things looks good! Nice work.

@rajadain

Copy link
Copy Markdown
Collaborator

Bus & Train is also missing in the translations file, but specified in the source Google Doc. I would recommend doing one more pass on the Chinese to ensure that all non-translated items are sourced, where available, from the Google Doc.

@rajadain rajadain assigned simonkassel and unassigned rajadain Apr 30, 2026
@simonkassel

Copy link
Copy Markdown
Collaborator Author

Good catches, thanks. I cleaned up Favorites and Favorite Neighborhoods in the translations file. I think Bus & Train was already translated? you may have been looking at an earlier commit. Regardless, I looked over the tranlations json file and I think everything else is accounted for.

@simonkassel

Copy link
Copy Markdown
Collaborator Author

I also took another pass at the spanish translations file and I believe everything is translated in there as well

@simonkassel simonkassel requested a review from rajadain May 1, 2026 02:31
@simonkassel simonkassel assigned rajadain and unassigned simonkassel May 1, 2026

@rajadain rajadain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes you're right, I was looking at the wrong thing for Bus & Train. Everything in the Google Doc now exists in the translation files. Thanks! Nice work!

@rajadain rajadain assigned simonkassel and unassigned rajadain May 1, 2026
@simonkassel simonkassel merged commit 2ea5a8f into develop May 1, 2026
2 checks passed
@simonkassel simonkassel deleted the sk/translations branch May 1, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update remaining translations with final copy

2 participants