Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpellPowerBonus now scales with gear bonus instead of level #56

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

lucafolloni
Copy link

Changes Proposed:

  • Make spell power bonus scale with gear instead of level

Tests Performed:

  • Tested in game

How to Test the Changes:

  1. Create a caster class (e.g. warlock)
  2. Login into game
  3. Enter dungeon
  4. Check spellpower bonus
  5. Change gear
  6. Repeat steps steps 3-5 as much as needed

@Helias
Copy link
Member

Helias commented Mar 6, 2025

Ciao 👋 !

Are you sure that is better to scale it based on gear instead of level?

@lucafolloni
Copy link
Author

Hi @Helias.

I tested this on a private server with two other people.
The reason behind this is that whereas the bonus looks very high when a character just got level 80, it becomes less useful as you move raids such as ToC and ICC.
Moreover, while melee DPSes benefit from the increased strength being converted to attack power, casters do not have such a strong sp increase.
This aims to balance the different behavior.
That being said, the multiplier in the config should also be set to 1.0 as a default. I already did it on my server, but forgot to add it to the git repo.

I'm fixing it right away.
Sorry for that and for the WoT 😉

@Helias Helias merged commit 09c192e into azerothcore:master Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants