Fixes text output formatting due to core change #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes module output text formatting due to core change. <!-- If your fix has a relating issue, link it below --> - Closes 48 <!-- If you can, include a source that can strengthen your claim --> #48 (comment) <!-- Does it build without errors? Did you test in-game? What did you test? On which OS did you test? Describe any other tests performed --> - Recompiled - Tested various dungeons at, below, and above my characters level - Noted proper output <!-- Describe in a detailed step-by-step order how to test the changes --> 1.create a level 40 character 2.visit low, mid and high level dungeons 3.verify proper output
Helias
approved these changes
Mar 19, 2025
|
thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
fmtazerothcore-wotlk#19490Issues Addressed:
SOURCE:
#48 (comment)
Tests Performed:
How to Test the Changes:
Additional credit: https://github.com/Povotech (#48 (comment)) as I used their example as the starting point.