Skip to content

Conversation

@devnix
Copy link
Contributor

@devnix devnix commented Jan 20, 2025

Initial PR for #502 before changing the implementation.

It's the first time I use PHPBench, so I would love any early feedback while I try to give coverage to all the component 😄

@coveralls
Copy link

coveralls commented Jan 20, 2025

Pull Request Test Coverage Report for Build 13230804660

Details

  • 17 of 18 (94.44%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 98.466%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Psl/Shell/stream_unpack.php 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/Psl/Async/KeyedSemaphore.php 1 97.83%
Totals Coverage Status
Change from base Build 13067986688: 0.001%
Covered Lines: 5326
Relevant Lines: 5409

💛 - Coveralls

@devnix devnix force-pushed the collection-benchmarks branch from 99a583b to bb05a54 Compare January 29, 2025 21:38
@devnix devnix force-pushed the collection-benchmarks branch from bb05a54 to 903a56f Compare February 9, 2025 23:27
@azjezz
Copy link
Owner

azjezz commented Mar 24, 2025

@devnix please do a git reset --hard origin/next and cherry-pick your commits on top then git push -f to have cleaner history.

@devnix devnix force-pushed the collection-benchmarks branch from b2d9073 to c06bd62 Compare March 24, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants