New math intrinsics #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKozlov
requested changes
Jun 19, 2020
Comment on lines
1264
to
1278
| __ bind(Lnan1); | ||
| if (double_precision) { | ||
| __ fmind(F10_RET, F10_ARG0, F10_ARG0); | ||
| } else { | ||
| __ fmins(F10_RET, F10_ARG0, F10_ARG0); | ||
| } | ||
| __ mv(R2_SP, R21_sender_SP); | ||
| __ ret(); | ||
|
|
||
| __ bind(Lnan2); | ||
| if (double_precision) { | ||
| __ fmind(F10_RET, F11_ARG1, F11_ARG1); | ||
| } else { | ||
| __ fmins(F10_RET, F11_ARG1, F11_ARG1); | ||
| } |
There was a problem hiding this comment.
https://docs.oracle.com/javase/7/docs/api/java/lang/Math.html#min(double,%20double)
-- If either value is NaN, then the result is NaN
Are you trying to canonicalize the value?
Spec doesn't impose which NaN should it be, I think it safe to return any (the NaN argument for example)
There was a problem hiding this comment.
replaced fmind/fmins with fmvd/fmvs.
Comment on lines
812
to
813
| do_intrinsic(_min, java_lang_Math, min_name, int2_int_signature, F_S) \ | ||
| do_intrinsic(_max, java_lang_Math, max_name, int2_int_signature, F_S) \ |
There was a problem hiding this comment.
It's better to preserve original identifiers even if we would have min and minL. Various shared code could depend on names (JIT compilers for example)
There was a problem hiding this comment.
Restored _min/_max and abs symbols.
Comment on lines
192
to
194
| case vmIntrinsics::_dabs : return java_lang_math_absD ; | ||
| #else | ||
| case vmIntrinsics::_dabs : return java_lang_math_abs ; |
There was a problem hiding this comment.
same here, let's stick to original identifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.