-
Notifications
You must be signed in to change notification settings - Fork 202
Trademo branch #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trademo branch #95
Conversation
| @@ -0,0 +1,73 @@ | |||
| # Trademo Shipments and Tariff Tool | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the title, please just use the tool name. I would recommend "Trademo" or "Trademo Shipments and Tariff"
| This Python script demonstrates how to use Azure AI to create an agent that queries global trade duties using an OpenAPI specification. | ||
|
|
||
| ## About Tool: | ||
| - Name: Trademo_Shipments_And_Tariff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the description we received earlier, could you please update to this one?
Provides latest duties and past shipment data for trade between multiple countries
| This Python script demonstrates how to use Azure AI to create an agent that queries global trade duties using an OpenAPI specification. | ||
|
|
||
| ## About Tool: | ||
| - Name: Trademo_Shipments_And_Tariff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we update the tool name in blog or ux, wont have "_"between words
samples/microsoft/python/getting-started-agents/3p-tools/Trademo_Global_trade/ReadME.md
Show resolved
Hide resolved
|
|
||
| Set this environment variables with your own values: | ||
| PROJECT_ENDPOINT - the Azure AI Project endpoint, as found in your Foundry Project. | ||
| PROJECT_OPENAPI_CONNECTION_NAME - the connection name for the OpenAPI connection authentication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will need either connection name or the connection id, dont need both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the new code makes use of connection id, hence I removed connection name.
.../microsoft/python/getting-started-agents/3p-tools/Trademo_Global_trade/trademo_and_tariff.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont have to include the logo file in this PR since we got the approval and the logo through email
| run_steps = project_client.agents.run_steps.list(thread_id=thread.id, run_id=run.id) | ||
|
|
||
| # Loop through each step to display information | ||
| for step in run_steps.data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line should be:
for step in run_steps:
First PR.
Added New sdk python code