[AutoPR @azure-rest/ai-document-intelligence] test #12687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
force-pushed
the
sdkAuto/3557/@azure-rest_ai-document-intelligence
branch
from
449a319 to
0874d48
Compare
wanlwanl
reviewed
Nov 4, 2024
| @@ -1078,7 +1078,7 @@ export interface DocumentKeyValuePairOutput { | |||
| // @public | |||
| export interface DocumentLanguageOutput { | |||
| confidence: number; | |||
| locale: string; | |||
| locale: number; | |||
There was a problem hiding this comment.
References: locala -> DocumentLanguageOutput -> AnalyzeResultOutput -> AnalyzeResultOperationOutput -> GetAnalyzeResult200Response and GetClassifyResult200Response , so anything used these responses get impacted.
e.g.
// @public (undocumented)
export function isUnexpected(response: GetClassifyResult200Response | GetClassifyResultDefaultResponse): response is GetClassifyResultDefaultResponse;
wanlwanl
reviewed
Nov 4, 2024
| - Added function overload "export function getLongRunningPoller<TResult extends BuildClassifierLogicalResponse | BuildClassifierDefaultResponse>(client: Client, initialResponse: BuildClassifier202Response | BuildClassifierDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" | ||
| - Added function overload "export function getLongRunningPoller<TResult extends CopyClassifierToLogicalResponse | CopyClassifierToDefaultResponse>(client: Client, initialResponse: CopyClassifierTo202Response | CopyClassifierToDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" | ||
| - Added function overload "export function getLongRunningPoller<TResult extends AnalyzeDocumentFromStreamLogicalResponse | AnalyzeDocumentFromStreamDefaultResponse>(client: Client, initialResponse: AnalyzeDocumentFromStream202Response | AnalyzeDocumentFromStreamDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" | ||
| - Added function overload "export function getLongRunningPoller<TResult extends ClassifyDocumentFromStreamLogicalResponse | ClassifyDocumentFromStreamDefaultResponse>(client: Client, initialResponse: ClassifyDocumentFromStream202Response | ClassifyDocumentFromStreamDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" |
There was a problem hiding this comment.
from the 1st one to this one, type SimplePollerLike is changed, so it's marked as new function
wanlwanl
reviewed
Nov 4, 2024
|
|
||
| - Removed operation SimplePollerLike.getOperationId | ||
| - Type of parameter locale of interface DocumentLanguageOutput is changed from string to number | ||
| - Removed function overload "export function getLongRunningPoller<TResult extends AnalyzeBatchDocumentsLogicalResponse | AnalyzeBatchDocumentsDefaultResponse>(client: Client, initialResponse: AnalyzeBatchDocuments202Response | AnalyzeBatchDocumentsDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" |
There was a problem hiding this comment.
from the this one, type SimplePollerLike is changed, so it's marked as new function
There was a problem hiding this comment.
as you can see, the current tool can detect indirect changes in type, which can't be detected from old tool.
the current output is confusing, since it use the same format to old tool.
since sdk suppression file is not intended to live long, we can consider improve changelog item by adding more change details in next pr, like "xxx is changed from A to B", "Function Func has new signature '...' due to A changed to B causing ParaA to ParaB"
wanlwanl
reviewed
Nov 4, 2024
| - Removed function overload "export function getLongRunningPoller<TResult extends CopyClassifierToLogicalResponse | CopyClassifierToDefaultResponse>(client: Client, initialResponse: CopyClassifierTo202Response | CopyClassifierToDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" | ||
| - Removed function overload "export function getLongRunningPoller<TResult extends AnalyzeDocumentFromStreamLogicalResponse | AnalyzeDocumentFromStreamDefaultResponse>(client: Client, initialResponse: AnalyzeDocumentFromStream202Response | AnalyzeDocumentFromStreamDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" | ||
| - Removed function overload "export function getLongRunningPoller<TResult extends ClassifyDocumentFromStreamLogicalResponse | ClassifyDocumentFromStreamDefaultResponse>(client: Client, initialResponse: ClassifyDocumentFromStream202Response | ClassifyDocumentFromStreamDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" | ||
| - Removed function overload "export function isUnexpected(response: GetAnalyzeResult200Response | GetAnalyzeResultDefaultResponse): response is GetAnalyzeResultDefaultResponse;" |
There was a problem hiding this comment.
due to type GetAnalyzeResult200Response is changed
wanlwanl
reviewed
Nov 4, 2024
| - Removed function overload "export function getLongRunningPoller<TResult extends AnalyzeDocumentFromStreamLogicalResponse | AnalyzeDocumentFromStreamDefaultResponse>(client: Client, initialResponse: AnalyzeDocumentFromStream202Response | AnalyzeDocumentFromStreamDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" | ||
| - Removed function overload "export function getLongRunningPoller<TResult extends ClassifyDocumentFromStreamLogicalResponse | ClassifyDocumentFromStreamDefaultResponse>(client: Client, initialResponse: ClassifyDocumentFromStream202Response | ClassifyDocumentFromStreamDefaultResponse, options?: CreateHttpPollerOptions<TResult, OperationState<TResult>>): Promise<SimplePollerLike<OperationState<TResult>, TResult>>;" | ||
| - Removed function overload "export function isUnexpected(response: GetAnalyzeResult200Response | GetAnalyzeResultDefaultResponse): response is GetAnalyzeResultDefaultResponse;" | ||
| - Removed function overload "export function isUnexpected(response: GetClassifyResult200Response | GetClassifyResultDefaultResponse): response is GetClassifyResultDefaultResponse;" |
There was a problem hiding this comment.
due to GetClassifyResult200Response is changed
| ## 1.0.0-beta.3 (#2024-08-20) | ||
| ### Breaking Changes | ||
|
|
||
| - Removed operation SimplePollerLike.getOperationId |
| ### Breaking Changes | ||
|
|
||
| - Removed operation SimplePollerLike.getOperationId | ||
| - Type of parameter locale of interface DocumentLanguageOutput is changed from string to number |
azure-sdk
force-pushed
the
sdkAuto/3557/@azure-rest_ai-document-intelligence
branch
from
0874d48 to
287c29f
Compare
Merge a89ef2b585a9b3295c736d58d3ef992efe554eab into 2e448dc49e1db016778f5f077eaa30cc2ce7e85b
azure-sdk
force-pushed
the
sdkAuto/3557/@azure-rest_ai-document-intelligence
branch
from
287c29f to
05d1e05
Compare
azure-sdk
deleted the
sdkAuto/3557/@azure-rest_ai-document-intelligence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync test-repo-billy/azure-rest-api-specs#3557
This pull request has been automatically generated for preview purposes.