Remove Whitsunday (pentecost) from Austria#379
Conversation
It's not a holiday: https://en.wikipedia.org/wiki/Public_holidays_in_Austria https://de.wikipedia.org/wiki/Feiertage_in_%C3%96sterreich Signed-off-by: Felix Frey <felix.frey@gmx.at>
|
@felixfrey Indeed Whitsunday is not an official public holiday in Austria, but is a major religious observance (As mentioned here https://publicholidays.at/pentecost/ and here https://www.timeanddate.com/holidays/austria/pentecost-sunday). In Yasumi, Whitsunday is registered for Austria, but not classified as an official holiday. It is classified as "Observance", as you can see in the documentation https://www.yasumi.dev/providers/at.html#holidays and in the source code here: yasumi/src/Yasumi/Provider/Austria.php Line 58 in c747552 So I don't think it needs to be removed. |
|
@stelgenhof You are right. I missed the part of the documentation where it explains the filtering methods for holidays. That solves my use case and I hope the filter by type does not break anything for other countries in my code. |
It's not a holiday:
https://en.wikipedia.org/wiki/Public_holidays_in_Austria
https://de.wikipedia.org/wiki/Feiertage_in_%C3%96sterreich