Skip to content

Remove Whitsunday (pentecost) from Austria#379

Closed
felixfrey wants to merge 1 commit into
azuyalabs:developfrom
felixfrey:develop
Closed

Remove Whitsunday (pentecost) from Austria#379
felixfrey wants to merge 1 commit into
azuyalabs:developfrom
felixfrey:develop

Conversation

@felixfrey

Copy link
Copy Markdown

@stelgenhof

Copy link
Copy Markdown
Member

@felixfrey Indeed Whitsunday is not an official public holiday in Austria, but is a major religious observance (As mentioned here https://publicholidays.at/pentecost/ and here https://www.timeanddate.com/holidays/austria/pentecost-sunday).

In Yasumi, Whitsunday is registered for Austria, but not classified as an official holiday. It is classified as "Observance", as you can see in the documentation https://www.yasumi.dev/providers/at.html#holidays and in the source code here:

$this->addHoliday($this->pentecost($this->year, $this->timezone, $this->locale, Holiday::TYPE_OBSERVANCE));
.

So I don't think it needs to be removed.

@felixfrey

Copy link
Copy Markdown
Author

@stelgenhof You are right. I missed the part of the documentation where it explains the filtering methods for holidays. That solves my use case and I hope the filter by type does not break anything for other countries in my code.

@felixfrey felixfrey closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants