Added provider for closures of New York Stock Exchange (NYSE) since 2000#384
Merged
Conversation
added 3 commits
August 11, 2025 02:32
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
Member
|
@mgwebgroup It all looks good, except you have some minor coding style issues :) |
Contributor
Author
|
Thanks, Sacha. I’ll run PHP-CS-Fixer locally and clean up the coding style issues. |
Member
|
@mgwebgroup Thanks! I would recommend to put any comments and attributions in the class docblock. The file docblock is autogenerated (gets overwritten with each release). |
added 2 commits
August 18, 2025 17:23
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
Contributor
Author
|
@stelgenhof Changes pushed. |
Member
|
@mgwebgroup Your PR is failing on the testing part; seems a small issue with your code. Thanks for checking. |
…ider Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
stelgenhof
approved these changes
Sep 1, 2025
stelgenhof
pushed a commit
that referenced
this pull request
Sep 1, 2025
Added a holiday provider to track holidays and closures for the New York Stock Exchange. In addition to observed holidays, the closures include emergency, weather and presidential proclamation events since year 2000. Other US exchanges like NASDAQ and CBOE normally follow suit for holidays and closures. This PR supersedes PR #382. --------- Signed-off-by: Art Kurbakov <admin@mgwebgroup.com> Co-authored-by: Art Kurbakov <admin@mgwebgroup.com>
stelgenhof
pushed a commit
that referenced
this pull request
Sep 1, 2025
Added a holiday provider to track holidays and closures for the New York Stock Exchange. In addition to observed holidays, the closures include emergency, weather and presidential proclamation events since year 2000. Other US exchanges like NASDAQ and CBOE normally follow suit for holidays and closures. This PR supersedes PR #382. --------- Signed-off-by: Art Kurbakov <admin@mgwebgroup.com> Co-authored-by: Art Kurbakov <admin@mgwebgroup.com>
hamrak
pushed a commit
to hamrak/yasumi
that referenced
this pull request
Nov 11, 2025
Added a holiday provider to track holidays and closures for the New York Stock Exchange. In addition to observed holidays, the closures include emergency, weather and presidential proclamation events since year 2000. Other US exchanges like NASDAQ and CBOE normally follow suit for holidays and closures. This PR supersedes PR azuyalabs#382. --------- Signed-off-by: Art Kurbakov <admin@mgwebgroup.com> Co-authored-by: Art Kurbakov <admin@mgwebgroup.com> Signed-off-by: Ján Hamrák <hamrak@kcorp.sk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes PR #382.
Added a holiday provider to track holidays and closures for the New York Stock Exchange. In addition to observed holidays, the closures include emergency, weather and presidential proclamation events since year 2000. Other US exchanges like NASDAQ and CBOE normally follow suit for holidays and closures.