feat: add Ecuador holiday provider#406
Closed
giovanny07 wants to merge 1 commit into
Closed
Conversation
Improved the contribution guidelines as it was missing a few essential
pointers:
- Added guidance on Conventional Commits.
- Added DCO sign-off requirement with example command.
- Added branching strategy (branch off develop, target develop).
- Added a "Before Submitting" section with the full composer cs /
composer phpstan / composer test checklist.
Additionnally corrected the PHPUnit version mentioned in the AGENTS.md
file. Furthermore, updated/corrected the list of supported versions in
SECURITY.md and replaced the public issue link for vulnerability reporting
with GitHub's private security advisory URL to prevent disclosing
unpatched vulnerabilities publicly.
Signed-off-by: Sacha Telgenhof <me@sachatelgenhof.com>
Signed-off-by: Giovanny Rodriguez <giovanny.rodriguez@imagunet.com>
giovanny07
changed the title
Member
|
@giovanny07 Your commit in this PR looks a bit odd, as it contains changes (squashed?) from commit 398caf6. I recommend to rebase and have your branch only contain changes related to the new Ecuador provider. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Ecuador (EC) holiday provider with 11 national holidays established
by Article 65 of the Código del Trabajo and the Ley Orgánica Reformatoria
a la LOSEP y al Código del Trabajo (R.O. Suplemento No. 906, Dec 2016).
Fixed holidays (never transferred):
Transferable holidays (Reforma 2016 rule):
Tue → Mon; Wed/Thu/Sat → Fri; Sun → Mon; Mon/Fri unchanged:
Includes 13 test files with testTransferRule() coverage for all
transferable holidays and year-guard tests for historical holidays.