feat(Australia): refresh holiday rules and rename Queen's Birthday to Monarch's Birthday#410
Merged
Merged
Conversation
8e73427 to
e782c68
Compare
stelgenhof
requested changes
Apr 24, 2026
stelgenhof
left a comment
Member
There was a problem hiding this comment.
@aaronflorey Thank you so much! I have reviewed your PR and it is looking very solid. The only few (non-critical) observations are these
- Consider adding a deprecated alias (
queensBirthday→monarchsBirthday) to ease migration for downstream consumers - Extract year thresholds (2023, 2024, etc.) into constants for easier maintenance
e.g.:
private const MONARCHY_CHANGE_YEAR = 2023;
private const SA_EASTER_SUNDAY_YEAR = 2024;
- Add specific test for 2022–2023 transition to verify both holiday names appear correctly
stelgenhof
requested changes
Apr 29, 2026
stelgenhof
left a comment
Member
There was a problem hiding this comment.
Thanks for the last improvements! All looking very good. There is one small issue left (DCO): see https://github.com/azuyalabs/yasumi/pull/410/checks. Once that is taken care of, it can be merged
Signed-off-by: Aaron Florey <azza@jcaks.net>
Signed-off-by: Aaron Florey <azza@jcaks.net>
d3a8410 to
bbbd1da
Compare
stelgenhof
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing