Skip to content

feat(Australia): refresh holiday rules and rename Queen's Birthday to Monarch's Birthday#410

Merged
stelgenhof merged 2 commits into
azuyalabs:developfrom
aaronflorey:australian-holidays
May 1, 2026
Merged

feat(Australia): refresh holiday rules and rename Queen's Birthday to Monarch's Birthday#410
stelgenhof merged 2 commits into
azuyalabs:developfrom
aaronflorey:australian-holidays

Conversation

@aaronflorey

Copy link
Copy Markdown
Contributor

Summary

  • update Australian state and territory providers to reflect current holiday rules and timezone handling
  • rename Queen's Birthday references to Monarch's Birthday and add the new translation data
  • add and update coverage for regional holiday behavior, including Anzac Day Monday observance and Easter Sunday/Saturday cases where applicable

Testing

  • existing Australia provider tests updated to cover the revised holiday definitions
  • new tests added for state- and region-specific edge cases across affected providers

@aaronflorey aaronflorey force-pushed the australian-holidays branch from 8e73427 to e782c68 Compare April 13, 2026 03:49
@aaronflorey aaronflorey marked this pull request as draft April 15, 2026 23:13

@stelgenhof stelgenhof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronflorey Thank you so much! I have reviewed your PR and it is looking very solid. The only few (non-critical) observations are these

  • Consider adding a deprecated alias (queensBirthdaymonarchsBirthday) to ease migration for downstream consumers
  • Extract year thresholds (2023, 2024, etc.) into constants for easier maintenance

e.g.:

    private const MONARCHY_CHANGE_YEAR = 2023;
    private const SA_EASTER_SUNDAY_YEAR = 2024;
  • Add specific test for 2022–2023 transition to verify both holiday names appear correctly

@aaronflorey aaronflorey marked this pull request as ready for review April 29, 2026 04:34
@aaronflorey aaronflorey requested a review from stelgenhof April 29, 2026 04:34

@stelgenhof stelgenhof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the last improvements! All looking very good. There is one small issue left (DCO): see https://github.com/azuyalabs/yasumi/pull/410/checks. Once that is taken care of, it can be merged

Signed-off-by: Aaron Florey <azza@jcaks.net>
Signed-off-by: Aaron Florey <azza@jcaks.net>
@aaronflorey aaronflorey force-pushed the australian-holidays branch from d3a8410 to bbbd1da Compare May 1, 2026 01:38
@aaronflorey aaronflorey requested a review from stelgenhof May 1, 2026 01:39
@stelgenhof stelgenhof merged commit dd814f0 into azuyalabs:develop May 1, 2026
25 checks passed
@aaronflorey aaronflorey deleted the australian-holidays branch May 10, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants