handle unparseable stack trace better#24
Merged
Conversation
jduthon
marked this pull request as ready for review
March 4, 2026 06:58
jduthon
changed the title
mangs
approved these changes
Mar 4, 2026
mangs
left a comment
mangs
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the catch, looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are receiving rollbar errors caused by unhandled promise rejections originating from the library.
The issue seems to be some errors we are sending in do not have a stack trace (or at least a stack trace considered valid from the perspective of the error-stack-parser library, so we receive this error.
This is not ideal as it adds unactionnable noise and we don't know what error we sent in caused the problem.
This PR proposes to avoid throwing errors and letting the errors be reported with empty stack frames.
Changes: