Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added file drop/upload/download capabilities to repl2 #1344

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ericponto
Copy link

@ericponto ericponto commented Aug 24, 2017

Added an Upload and Download button to the new options menu on REPL 2. Also added the ability to drop a file anywhere in the REPL and have the code show up/get compiled.

@babel-bot
Copy link
Contributor

babel-bot commented Aug 24, 2017

Deploy preview for babel ready!

Built with commit c7d9402

https://deploy-preview-1344--babel.netlify.com

@xtuc
Copy link
Member

xtuc commented Aug 24, 2017

Awesome, nice job. It works in the preview.

@ericponto
Copy link
Author

I can get this merge conflicts handled tonight with the accordion side bar changes if this feature is wanted.

@ericponto
Copy link
Author

I got this updated with the new way sidebar tabs are persisted.

@ericponto
Copy link
Author

With the pick any plugin feature added, the REPL is getting to the point that it can pretty much handle any scenario. Having the file capabilities would be nice for people who don't want to set up any sort of process but still want to transpire their code as a one off.

I'm curious if others feel this way, and if i should continue to keep this PR up to date.

@shobhitchittora
Copy link

@ericponto Great work on this! I do think this would be a good improvement to add to the repl.

@JLHwung JLHwung self-requested a review December 10, 2019 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants