Conversation
| pos := 1 | ||
|
|
||
| err := rpcClient.WalletPassphrase("pass", 60) | ||
| //Add password in here for remote/dynamically |
There was a problem hiding this comment.
if you don't plan to fix in this PR, add a TODO
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
harness/app.go
Outdated
| go printStatsForever(ctx, tm, stopChan, cfg) | ||
|
|
||
| covenantSender, err := NewSenderWithBabylonClient(ctx, "covenant", tm.Config.Babylon0.RPCAddr, tm.Config.Babylon0.GRPCAddr) | ||
| covenantSender, err := NewSenderWithBabylonClient(ctx, "covenant", tm.Config.Babylon0.RPCAddr, tm.Config.Babylon0.GRPCAddr, tm.Config.Babylon0.ChainID, "test") |
There was a problem hiding this comment.
Bug: Incorrect Parameter Order in Client Configuration
It looks like the NewSenderWithBabylonClient calls are passing chainId and grpcaddr in the wrong order. This swap means clients are getting configured with incorrect network details, which could lead to connection issues across the harness.
Additional Locations (4)
harness/babylonclient.go
Outdated
|
|
||
| if err != nil { | ||
| return err | ||
| log.Fatalf("send error: %v", err) |
There was a problem hiding this comment.
Bug: FundSenders Errors Cause Program Termination
The FundSenders function now uses log.Fatalf for transaction send errors, which terminates the program instead of returning the error. This breaks the function's error handling contract, preventing callers from gracefully recovering from transaction failures.
samricotta
force-pushed
the
sam/stakers-start
branch
from
e5593ef to
7f89ce7
Compare
.github/workflows/ci.yml
Outdated
| install-dependencies-command: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libzmq3-dev No newline at end of file | ||
| go-version: '1.23' |
There was a problem hiding this comment.
ah think this is my auto linting working its magic
harness/btcstaker.go
Outdated
| stakerPk, | ||
| unbondingTime, | ||
| params.UnbondingFeeSat, | ||
| 100_010, |
There was a problem hiding this comment.
why do we want to use this magic number and not from params?
There was a problem hiding this comment.
This I actually calculated a month or so ago but when building the slashing tx from staking tx, the program would complain that the params.UnbondingFeeSat was too high. This was the exact number needed for it to succeed
harness/manager.go
Outdated
| babylonTag = []byte{1, 2, 3, 4} //nolint:unused | ||
| eventuallyWaitTimeOut = 40 * time.Second | ||
| eventuallyPollTime = 1 * time.Second | ||
| eventuallyWaitTimeOut = 1800 * time.Second // 30 minutes for CI |
There was a problem hiding this comment.
why do we suddenly need increase from 40s to 30min? We didn't change the logic for sandbox e2e
Makefile
Outdated
|
|
||
| test-e2e: | ||
| go test -mod=readonly -failfast -timeout=15m -v $(PACKAGES_E2E) -count=1 | ||
| go test -mod=readonly -failfast -timeout=35m -v $(PACKAGES_E2E) -count=1 |
There was a problem hiding this comment.
there must be something wrong if out e2e needs 35min to finish
samricotta
force-pushed
the
sam/stakers-start
branch
from
5a771cc to
1b8b044
Compare
samricotta
force-pushed
the
sam/stakers-start
branch
from
11d7578 to
73ead19
Compare
samricotta
force-pushed
the
sam/stakers-start
branch
from
42e0e01 to
0de548f
Compare
Lazar955
left a comment
Lazar955
left a comment
There was a problem hiding this comment.
I think we are ready to open PR from adding-remote to main?
container/container.go
Outdated
| "sed -i -e 's/iavl-disable-fastnode = true/iavl-disable-fastnode = %s/' /home/node1/babylond/config/app.toml && "+ | ||
| `sed -i -e 's/timeout_commit = "5s"/timeout_commit = "2s"/' /home/node1/babylond/config/config.toml &&`+ | ||
| "babylond start --home=/home/node1/babylond --rpc.pprof_laddr=0.0.0.0:6060", | ||
| "export BABYLON_BLS_PASSWORD=password && babylond start --home=/home/node1/babylond --rpc.pprof_laddr=0.0.0.0:6060", |
There was a problem hiding this comment.
why do we set BABYLON_BLS_PASSWORD twice?
| var stakers []*BTCStaker | ||
| for i := 0; i < numStakers; i++ { | ||
| stakerSender, err := NewSenderWithBabylonClient(ctx, fmt.Sprintf("staker-%d", i), tm.Config.Babylon1.RPCAddr, tm.Config.Babylon1.GRPCAddr) | ||
| stakerSender, err := NewSenderWithBabylonClient(ctx, fmt.Sprintf("staker-%d", i), tm.Config.Babylon1.RPCAddr, tm.Config.Babylon0.ChainID, tm.Config.Babylon1.GRPCAddr, "test") |
There was a problem hiding this comment.
let's have a const for "test" backend keyring
2 participants
No description provided.