Skip to content

fix(ci): add permissions and bump docker pipeline to v0.16.1#775

Open
mpastecki wants to merge 1 commit intomainfrom
fix/ci-workflow-permissions
Open

fix(ci): add permissions and bump docker pipeline to v0.16.1#775
mpastecki wants to merge 1 commit intomainfrom
fix/ci-workflow-permissions

Conversation

@mpastecki
Copy link
Contributor

Add job-level permissions for docker_pipeline job.

Required by reusable_docker_pipeline.yml:

  • contents: read - checkout access
  • id-token: write - AWS OIDC authentication
  • security-events: write - Trivy SARIF uploads

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds job-level permissions to the docker_pipeline job in the CI workflow and bumps the reusable Docker pipeline version from v0.13.4 to v0.16.1.

Changes:

  • Added explicit permissions for the docker_pipeline job (contents: read, id-token: write, security-events: write)
  • Updated the reusable Docker pipeline workflow reference from commit 5151754256060bf160c411d0784f831f29882106 (v0.13.4) to d2299e834fcbaca4bf2db043a2939798043d5951 (v0.16.1)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +33 to +37
permissions:
contents: read # Required by reusable workflow
id-token: write # Required for AWS OIDC
security-events: write # Required for Trivy SARIF uploads
uses: babylonlabs-io/.github/.github/workflows/reusable_docker_pipeline.yml@d2299e834fcbaca4bf2db043a2939798043d5951 # v0.16.1
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permissions block should be placed after the uses, secrets, and with blocks, not before them. This is the established convention in the codebase as seen in .github/workflows/publish.yml:50-61, where the permissions block appears after the uses, secrets, and with blocks. This ordering is important in GitHub Actions YAML for reusable workflows.

The corrected order should be:

  1. uses
  2. secrets
  3. with
  4. permissions

Copilot uses AI. Check for mistakes.
@RafilxTenfen
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants