chore: update ci and publish workflow versions#781
Conversation
Greptile SummaryThis PR updates the CI and publish GitHub Actions workflows to align with changes made in Key changes:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
PR[Pull Request / Push / Tag] --> CG{Concurrency Group\nCancel in-progress?}
CG -->|New commit supersedes| CANCEL[Cancel old run]
CG -->|First or latest run| LT[lint_test\nreusable_go_lint_test v0.18.1]
LT --> E2E[e2e_babylon\nubuntu-22.04]
LT --> DP[docker_pipeline\nreusable_docker_pipeline v0.18.1]
DP --> TRIVY{Trivy Scan\ntrivy_nofail: true}
TRIVY -->|Vulnerabilities found| PASS[Pipeline still passes]
TRIVY -->|Clean| PASS
DP --> PUB{publish: false\nCI workflow}
PR2[Push to main/release/*\nor workflow_dispatch] --> LT2[lint_test\nreusable_go_lint_test v0.18.1]
LT2 --> E2E2[e2e_babylon\nubuntu-22.04]
LT2 --> DP2[docker_pipeline\nreusable_docker_pipeline v0.18.1]
DP2 --> TRIVY2{Trivy Scan\ntrivy_nofail: true}
TRIVY2 -->|Vulnerabilities found| PUB2[Image still published]
TRIVY2 -->|Clean| PUB2
Reviews (1): Last reviewed commit: "chore: update ci and publish workflow ve..." | Re-trigger Greptile |
| publish: false | ||
| dockerfile: ./Dockerfile | ||
| repoName: finality-provider | ||
| trivy_nofail: true |
There was a problem hiding this comment.
trivy_nofail: true silences vulnerability scan failures
Setting trivy_nofail: true in the docker_pipeline job means that Trivy security scan failures will no longer block the CI pipeline. While this avoids false-positive-induced CI flakiness, it also means that Docker images containing known vulnerabilities will pass CI without any gate. Consider whether this is intentional, or if a trivy_nofail: false (the default) with documented exceptions would better preserve security guardrails.
The same concern applies to publish.yml (line 60), where this setting additionally means potentially vulnerable images will be published to the registry without a blocking failure.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 581d4f9c12
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
Preserve security-events for the reusable docker pipeline
Setting the workflow-wide token to contents: read caps every job in this workflow, including the docker_pipeline call. GitHub computes job permissions from the workflow/job permissions blocks, and a called workflow can only maintain or reduce them, so reusable_docker_pipeline.yml@0adff9d no longer receives the security-events: write permission it uses for its upload-sarif steps on public repos. In this repository that means the Docker CI job will now fail on PRs as soon as Hadolint/Trivy tries to upload results to the Security tab.
Useful? React with 👍 / 👎.
Summary
ciworkflowciworkflow (to match chore: update publish workflow version babylon#1986)publishworkflow (to match chore: update publish workflow version babylon#1986)