Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

feat: use expansion visibility service - #1537

Merged
gbarkhatov merged 4 commits into
mainfrom
feat/expansion-visibility-service
Sep 4, 2025
Merged

feat: use expansion visibility service#1537
gbarkhatov merged 4 commits into
mainfrom
feat/expansion-visibility-service

Conversation

@gbarkhatov

Copy link
Copy Markdown
Contributor
  • Centralize complex visibility logic for staking expansion delegations

Closes #1530

Copilot AI review requested due to automatic review settings September 3, 2025 16:16

This comment was marked as outdated.

@jonybur
jonybur requested a review from Copilot September 3, 2025 21:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new hook useExpansionVisibilityService to centralize complex visibility logic for staking expansion delegations. The hook determines which delegations should be visible in different UI parts (Activity tab vs Verified Expansion Modal).

  • Centralizes delegation visibility logic into a dedicated service hook
  • Implements filtering rules for Activity tab and Verified Expansion Modal
  • Adds logic to detect broadcasted expansions and hide original transactions when appropriate

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/ui/common/hooks/services/useExpansionVisibilityService.ts Outdated
Comment thread src/ui/common/hooks/services/useExpansionVisibilityService.ts Outdated
Comment thread src/ui/common/hooks/services/useExpansionVisibilityService.ts Outdated
Comment thread src/ui/common/hooks/services/useExpansionVisibilityService.ts Outdated
Comment thread src/ui/common/hooks/services/useExpansionVisibilityService.ts Outdated
@gbarkhatov
gbarkhatov requested a review from jonybur September 4, 2025 06:09
@gbarkhatov
gbarkhatov merged commit 8b005ec into main Sep 4, 2025
6 checks passed
@gbarkhatov
gbarkhatov deleted the feat/expansion-visibility-service branch September 4, 2025 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

00 - Expansion - create useExpansionVisibilityService for managing expansion display logic

4 participants