Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix - tooltip not displaying properly #44

Merged
merged 6 commits into from
Aug 7, 2024
Merged

bugfix - tooltip not displaying properly #44

merged 6 commits into from
Aug 7, 2024

Conversation

jeremy-babylonlabs
Copy link
Collaborator

closes #42

@jeremy-babylonlabs
Copy link
Collaborator Author

jeremy-babylonlabs commented Aug 6, 2024 •
edited
Loading

need a rerun on the build due to test failed error

gbarkhatov
gbarkhatov approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@gbarkhatov gbarkhatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Are there any places where this can happen? Besides Stats?
  2. I thought we're hotfixing on main? @jrwbabylonlab @jeremy-babylonlabs. Don't forget to update the patch version

@jeremy-babylonlabs jeremy-babylonlabs changed the base branch from dev to main August 6, 2024 10:23
jeremy-babylonlabs added a commit that referenced this pull request Aug 6, 2024
@jeremy-babylonlabs
closes #44 and #45
d183182
gbarkhatov
gbarkhatov approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@gbarkhatov gbarkhatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to bump the patch

@jeremy-babylonlabs jeremy-babylonlabs force-pushed the fix/42-tooltip-not-displaying-properly-on-mobile branch from d183182 to 4fe2aad Compare August 6, 2024 10:44
@jeremy-babylonlabs jeremy-babylonlabs force-pushed the fix/42-tooltip-not-displaying-properly-on-mobile branch from 670e846 to 97f7f4b Compare August 6, 2024 11:20
@jrwbabylonlab jrwbabylonlab requested a review from vitsalis August 6, 2024 11:27
vitsalis
vitsalis reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional tooltip should not be added while we're in a feature freeze. Apart from that lgtm.

vitsalis
vitsalis requested changes Aug 6, 2024
View reviewed changes
@jeremy-babylonlabs jeremy-babylonlabs force-pushed the fix/42-tooltip-not-displaying-properly-on-mobile branch from 97f7f4b to ca5e0e7 Compare August 7, 2024 04:48
vitsalis
vitsalis approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only minor comment

@jeremy-babylonlabs jeremy-babylonlabs merged commit 576853d into main Aug 7, 2024
2 checks passed
@jeremy-babylonlabs jeremy-babylonlabs deleted the fix/42-tooltip-not-displaying-properly-on-mobile branch August 7, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbarkhatov gbarkhatov gbarkhatov approved these changes

@vitsalis vitsalis vitsalis approved these changes

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip not displaying properly on mobile phone
4 participants
@jeremy-babylonlabs @vitsalis @gbarkhatov @jrwbabylonlab