Skip to content

Add permissions for publish workflow#521

Merged
Lazar955 merged 1 commit intomainfrom
hiep/fix-publish
Jan 19, 2026
Merged

Add permissions for publish workflow#521
Lazar955 merged 1 commit intomainfrom
hiep/fix-publish

Conversation

@maiquanghiep
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 19, 2026 09:34
@Lazar955 Lazar955 merged commit 938be57 into main Jan 19, 2026
20 checks passed
@Lazar955 Lazar955 deleted the hiep/fix-publish branch January 19, 2026 09:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds permissions configuration to the lint_test job in the publish workflow to enable security event writing and package reading capabilities. The same permissions already exist in the docker_pipeline job.

Changes:

  • Added security-events: write and packages: read permissions to the lint_test job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +32 to +36
permissions:
# required for all workflows
security-events: write
# required to fetch internal or private CodeQL packs
packages: read
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permissions block is incorrectly nested under the with block. In GitHub Actions, when calling a reusable workflow, permissions should be a sibling key at the same level as uses, with, and if, not nested inside with. This incorrect placement will cause the workflow to fail or the permissions to be ignored. The permissions should be moved to the job level, aligned with the uses key.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants