chore: update reusable docker pipeline to v0.16.1#532
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable Docker pipeline workflow reference from v0.15.0 to v0.16.1, bringing enhanced security features including scan-before-push, secret scanning, and lint failure enforcement. The update introduces stricter default behaviors where security scans and linting now block publishing by default.
Changes:
- Updated
reusable_docker_pipeline.ymlreference from commit22ae8ed(v0.15.0) tod2299e8(v0.16.1)
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:55
- In v0.16.1, the default value for
push_to_dockerhubchanged fromtruetofalse(as noted in the PR description). If this workflow was previously pushing images to DockerHub, you may need to explicitly setpush_to_dockerhub: truein thewithsection to maintain that behavior. If DockerHub pushes are not required, this change is fine. Please verify whether DockerHub publishing is needed for this repository.
with:
publish: true
docker_scan: true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| )}} | ||
| needs: ["lint_test"] | ||
| uses: babylonlabs-io/.github/.github/workflows/reusable_docker_pipeline.yml@22ae8ed7a2ea5c80331758914c4e0ea732eea1ad # v0.15.0 | ||
| uses: babylonlabs-io/.github/.github/workflows/reusable_docker_pipeline.yml@d2299e834fcbaca4bf2db043a2939798043d5951 # v0.16.1 |
There was a problem hiding this comment.
The ci.yml workflow file still uses v0.15.0 of reusable_docker_pipeline.yml (at line 24 of ci.yml). For consistency and to ensure both CI and publish workflows use the same scanning and linting behavior, consider updating ci.yml to v0.16.1 as well. The v0.16.1 changes (lint failures blocking, scan-before-push, and secret scanning) would benefit the CI workflow too.
Summary
Updates
reusable_docker_pipeline.ymlto v0.16.1 (d2299e8).What changes in v0.16.1
dockerfile_lintis now a dependency ofdocker_build, so Hadolint failures will block image publishingWhat changed in v0.16.0
docker_scan: true,trivy_nofail: false,hadolint_nofail: falsepush_to_dockerhubnow defaults tofalsecache-fromfor push steps