-
Notifications
You must be signed in to change notification settings - Fork 30
fix(rust): make clawdstrike publishable on crates.io again #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
26aba75
fix(rust): align clawdstrike with published hushspec
bb-connor 18603a9
chore(vendor): drop hushspec publish artifacts
bb-connor e9921a3
chore(rust): point clawdstrike at crate-local readme
bb-connor 14ff996
fix(ci): restore publishability PR offline checks
bb-connor 7eb11f1
fix(rust): resolve publishability review findings
bb-connor f490f3e
fix(rust): preserve unset origin defaults on decompile
bb-connor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| use std::fs; | ||
| use std::path::PathBuf; | ||
|
|
||
| fn main() { | ||
| println!("cargo:rustc-check-cfg=cfg(has_nono_signal_mode)"); | ||
|
|
||
| let Ok(manifest_dir) = std::env::var("CARGO_MANIFEST_DIR").map(PathBuf::from) else { | ||
| return; | ||
| }; | ||
| let is_packaged_verify_build = manifest_dir | ||
| .components() | ||
| .collect::<Vec<_>>() | ||
| .windows(2) | ||
| .any(|window| { | ||
| matches!(window, [target, package] | ||
| if target.as_os_str() == "target" && package.as_os_str() == "package") | ||
| }); | ||
|
|
||
| let capability_path = manifest_dir.join("../../../infra/vendor/nono/src/capability.rs"); | ||
|
|
||
| let has_signal_mode = !is_packaged_verify_build | ||
| && fs::read_to_string(capability_path) | ||
| .map(|source| { | ||
| source.contains("pub enum SignalMode") && source.contains("fn signal_mode") | ||
| }) | ||
| .unwrap_or(false); | ||
|
|
||
| if has_signal_mode { | ||
| println!("cargo:rustc-cfg=has_nono_signal_mode"); | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build script missing rerun-if-changed for external file
Low Severity
The build script reads
infra/vendor/nono/src/capability.rsto decide whether to sethas_nono_signal_mode, but never emits acargo:rerun-if-changeddirective for that path. Without it, Cargo only reruns the script when files inside theclawdstrikepackage change. If thenonovendor source is updated to addsignal_mode()but noclawdstrikefile changes, the cfg flag stays stale atfalseandsignal_mode_labelsilently hard-codes"isolated"in attestation output—even when the sandbox actually allows signals.