feat: certification program with compliance templates and badges#24
feat: certification program with compliance templates and badges#24
Conversation
Implement enterprise certification program including: - Certification API endpoints and webhook handlers - Compliance templates for guards validation - SDK certification badge support for Python and TypeScript - V1 API rate limiting and versioning infrastructure - Guard-level certification metadata and compliance checks Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 539d478d15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if wants_png(&headers) { | ||
| return Err(V1Error::new( | ||
| StatusCode::NOT_IMPLEMENTED, | ||
| "NOT_IMPLEMENTED", | ||
| "PNG badge rendering is not implemented yet (use SVG or JSON).", | ||
| )); |
There was a problem hiding this comment.
Avoid rejecting badge requests with broad Accept headers
Because get_badge bails out whenever the Accept header contains image/png, any client that sends a broad Accept (e.g., browsers and <img> tags typically include image/png alongside image/svg+xml and */*) will always receive a 501, even though SVG rendering is supported. This makes the badge endpoint unusable in common browser/embed scenarios unless the caller hand-crafts the Accept header. Consider only treating PNG as requested when it is explicitly preferred (e.g., via a query param or by checking for image/png without image/svg+xml/application/json) so SVG/JSON can still be served.
Useful? React with 👍 / 👎.
|
Addressed the badge
CI is green on the latest commit. |
Summary
Test plan
🤖 Generated with Claude Code