Converge policy schema to 1.1.0 + migrate/parity/plugins#29
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c81c56b025
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (Array.isArray((child as any).custom_guards) && (child as any).custom_guards.length > 0) { | ||
| (out as any).custom_guards = (child as any).custom_guards; | ||
| } |
There was a problem hiding this comment.
When a policy uses extends with merge strategy merge, an explicit custom_guards: [] in the child does not override the base list because the override only happens when the array length is > 0. This means inherited custom guards continue to run even when the child policy tries to disable them by clearing the list. That can lead to unexpected guard execution in derived policies and makes it impossible to remove inherited custom guards without knowing their IDs. Consider treating a present-but-empty custom_guards as an intentional override.
Useful? React with 👍 / 👎.
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Testing