Audit fix/2026 02 10 remediation by bb-connor · Pull Request #53 · backbay-labs/clawdstrike

bb-connor · 2026-02-10T07:04:29Z

Summary

This PR delivers the Wave 1 + Wave 2 audit remediations for Clawdstrike and adds regression coverage plus remediation evidence docs.

Scope in this PR:

CS-AUDIT-001..006 remediation
CS-AUDIT2-001..007 remediation
Regression tests and hardening around remote extends, CONNECT proxy controls, IRM parsing, async/background limits, and session lock lifecycle
Audit closure docs under docs/audits/

What Changed

Remote extends hardening (`hush-cli` + `hushd`)

Enforced host allowlisting and private/non-public IP blocking on remote resolution paths.
Hardened git remote parsing:
- supports SCP-style remotes (including userless SCP form)
- rejects unsupported schemes (file:// etc.)
- avoids SCP misclassification for URL remotes.
Added commit/ref validation to reject unsafe tokens (including dash-prefixed refs).
Added -- separator placement before user-controlled ref token on git fetch path.

CONNECT proxy + `hush run` resource bounds

Added bounded event queue with explicit drop accounting.
Added in-flight proxy connection cap + rejection accounting.
Added header-read timeout (slowloris mitigation).
Added timeout for forwarded writer HTTP calls.
Added CONNECT SNI consistency checks for IP-target CONNECT flow.

IRM and policy robustness (`clawdstrike`)

Filesystem IRM: traversal detection tightened and normalization behavior hardened.
Network IRM: switched host extraction to strict URL parsing and normalization.
Policy extends: added explicit recursion depth guard.
Async guard runtime: bounded background in-flight execution and drop semantics.

Session lock lifecycle (`hushd`)

Added idle lock pruning and churn tests to prevent lock table growth.
Tightened lock cleanup semantics around termination paths.

Tests Added / Updated

Includes targeted regressions for:

CONNECT/SNI mismatch behavior
slowloris and in-flight cap behavior
bounded event forwarding behavior
IRM traversal and URL spoof parsing
remote extends scheme/ref validation and host allowlist enforcement
async guard background in-flight limits
session lock pruning/churn

Evidence Docs

docs/audits/2026-02-rust-security-correctness-audit.md
docs/audits/2026-02-10-remediation.md
docs/audits/2026-02-10-wave2-remediation.md

Follow-up

Wave 3 findings and pre-release posture/tooling are addressed in:

feat(security): ship pre-release security posture docs/tests/fuzz/CI #54

bb-connor · 2026-02-10T07:04:41Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b739d96e4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/services/hush-cli/src/remote_extends.rs

crates/services/hushd/src/remote_extends.rs

crates/services/hushd/src/session/mod.rs

…cally

bb-connor · 2026-02-10T16:02:00Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2128fef9fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/services/hush-cli/src/remote_extends.rs

crates/services/hushd/src/remote_extends.rs

bb-connor · 2026-02-10T18:19:42Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c27d75752e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/libs/clawdstrike/src/guards/path_allowlist.rs

crates/libs/clawdstrike/src/guards/forbidden_path.rs

bb-connor · 2026-02-10T18:43:56Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bffe1b10ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/services/hush-cli/src/remote_extends.rs

crates/services/hushd/src/remote_extends.rs

bb-connor · 2026-02-10T19:37:50Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 854c3a4457

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/libs/clawdstrike/src/irm/fs.rs

crates/services/hush-cli/src/hush_run.rs

…meout

bb-connor · 2026-02-10T20:03:05Z

@codex

chatgpt-codex-connector · 2026-02-10T20:13:01Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bb-connor · 2026-02-10T20:21:14Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b10f11fde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/libs/clawdstrike/src/irm/fs.rs

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

crates/services/hush-cli/src/remote_extends.rs Show resolved Hide resolved

crates/services/hushd/src/remote_extends.rs Show resolved Hide resolved

crates/services/hushd/src/session/mod.rs Outdated Show resolved Hide resolved

bb-connor changed the base branch from feat/sdr-execution to main February 10, 2026 07:32

bb-connor changed the base branch from main to feat/sdr-execution February 10, 2026 07:33

bb-connor added 8 commits February 10, 2026 10:51

docs(audits): add 2026-02 rust security correctness audit

f88bf09

fix(audit): remediate CS-AUDIT-001..006

03eac7d

fix(hush-cli): harden CONNECT proxy policy/resource bounds

3d75c65

fix(clawdstrike): fail closed on IRM path and URL spoof bypasses

91d6377

fix(remote-extends): validate git refs and block option injection

779f8f6

fix(policy): bound extends recursion and async background inflight

4d6a070

fix(audit): finalize remediation evidence and ipv6 parity

d9f989d

fix(review): parse userless SCP remotes and prune session locks atomi…

2128fef

…cally

bb-connor force-pushed the audit-fix/2026-02-10-remediation branch from b739d96 to 2128fef Compare February 10, 2026 15:53

bb-connor changed the base branch from feat/sdr-execution to main February 10, 2026 15:53

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

crates/services/hush-cli/src/remote_extends.rs Show resolved Hide resolved

crates/services/hushd/src/remote_extends.rs Show resolved Hide resolved

fix(remote-extends): treat scheme remotes as URLs before scp parsing

c27d757

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

crates/libs/clawdstrike/src/guards/path_allowlist.rs Outdated Show resolved Hide resolved

crates/libs/clawdstrike/src/guards/forbidden_path.rs Outdated Show resolved Hide resolved

fix(guards): preserve relative glob and exception compatibility

bffe1b1

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

crates/services/hush-cli/src/remote_extends.rs Outdated Show resolved Hide resolved

crates/services/hushd/src/remote_extends.rs Outdated Show resolved Hide resolved

fix(remote-extends): allow cached git policy resolution offline

854c3a4

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

crates/libs/clawdstrike/src/irm/fs.rs Outdated Show resolved Hide resolved

crates/services/hush-cli/src/hush_run.rs Outdated Show resolved Hide resolved

fix(security): tighten fs path extraction and honor forwarder test ti…

b8b3101

…meout

ci: remove redundant changed-paths workflow

8b356e7

Merge origin/main into audit-fix/2026-02-10-remediation

5b10f11

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

crates/libs/clawdstrike/src/irm/fs.rs Show resolved Hide resolved

fix(irm): treat dotted mime-like segments as filesystem paths

d63547a

bb-connor merged commit 76ac25c into main Feb 10, 2026
25 checks passed

bb-connor deleted the audit-fix/2026-02-10-remediation branch March 3, 2026 05:45

Conversation

bb-connor commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Remote extends hardening (hush-cli + hushd)

CONNECT proxy + hush run resource bounds

IRM and policy robustness (clawdstrike)

Session lock lifecycle (hushd)

Tests Added / Updated

Evidence Docs

Follow-up

Uh oh!

bb-connor commented Feb 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bb-connor commented Feb 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

bb-connor commented Feb 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

bb-connor commented Feb 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

bb-connor commented Feb 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

bb-connor commented Feb 10, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 10, 2026

Uh oh!

bb-connor commented Feb 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

bb-connor commented Feb 10, 2026 •

edited

Loading

Remote extends hardening (`hush-cli` + `hushd`)

CONNECT proxy + `hush run` resource bounds

IRM and policy robustness (`clawdstrike`)

Session lock lifecycle (`hushd`)