Skip to content

fix(examples): bind dev servers to loopback - #380

Closed
ffumero2003 wants to merge 1 commit into
mainfrom
fix-examples-bind-loopback
Closed

ffumero2003 wants to merge 1 commit into
mainfrom
fix-examples-bind-loopback

Conversation

@ffumero2003

Copy link
Copy Markdown
Contributor

Context

The example dev servers (browser-uploader, node-presigned-with-auth) call server.listen(PORT) with no host argument, so Node binds to all interfaces (0.0.0.0) even though they log http://localhost. These are local-only developer demos and should stay on the loopback interface.

Changes

  • Bind both example servers explicitly to 127.0.0.1 (loopback).
  • Add a short note that any real deployment must bind appropriately and serve over HTTPS.

Verification

  • pnpm typecheck:examples, pnpm typecheck, pnpm lint, pnpm build — all pass.
  • pnpm verify — 2,621 tests passed, 9 skipped.
  • Diff limited to the two example server files.

Closes #379

@ffumero2003 ffumero2003 self-assigned this Nov 13, 2026
@ffumero2003

Copy link
Copy Markdown
Contributor Author

Closing — per our security process a medium finding is reviewed on the private mirror first, then lands here as a neutral squash-merge PR. Moved to the private mirror (review PR); a neutral public PR will follow once approved.

@ffumero2003
ffumero2003 deleted the fix-examples-bind-loopback branch November 13, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bind example dev servers to loopback

1 participant