Repository navigation
fix(examples): bind dev servers to loopback - #380
Closed
ffumero2003 wants to merge 1 commit into
Closed
ffumero2003 wants to merge 1 commit into
ffumero2003 wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing — per our security process a medium finding is reviewed on the private mirror first, then lands here as a neutral squash-merge PR. Moved to the private mirror (review PR); a neutral public PR will follow once approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The example dev servers (
browser-uploader,node-presigned-with-auth) callserver.listen(PORT)with no host argument, so Node binds to all interfaces (0.0.0.0) even though they loghttp://localhost. These are local-only developer demos and should stay on the loopback interface.Changes
127.0.0.1(loopback).Verification
pnpm typecheck:examples,pnpm typecheck,pnpm lint,pnpm build— all pass.pnpm verify— 2,621 tests passed, 9 skipped.Closes #379