Skip to content

BA-XXX: add BackedWrappedOracleForwarder and BackedWrappedOracleForwarderFactory contract #35

Draft
0xChristof wants to merge 3 commits intoba-xxx-add-wrapped-tokenfrom
BA-XXX-wrapped-oracle-forwarder
Draft

BA-XXX: add BackedWrappedOracleForwarder and BackedWrappedOracleForwarderFactory contract #35
0xChristof wants to merge 3 commits intoba-xxx-add-wrapped-tokenfrom
BA-XXX-wrapped-oracle-forwarder

Conversation

@0xChristof
Copy link
Collaborator

No description provided.

@0xChristof 0xChristof added the wip label Mar 6, 2025
@leviadam
Copy link
Contributor

leviadam commented Mar 6, 2025

Thanks @0xChristof.

A few comments:

  1. I think that we can maybe assume that the decimals are the same in both origin and wrapper (but we can also keep this generic version)
  2. This implementation is very straight forward, which is good. We might want to think about someone changing the price via contribution to the wrapper. We should be carful about this.
  3. We must have tests

…y; add deployment script for WrappedOracleForwarderFactory
@0xChristof
Copy link
Collaborator Author

Thanks @0xChristof.

A few comments:

  1. I think that we can maybe assume that the decimals are the same in both origin and wrapper (but we can also keep this generic version)
  2. This implementation is very straight forward, which is good. We might want to think about someone changing the price via contribution to the wrapper. We should be carful about this.
  3. We must have tests

@leviadam Thanks for your comments! This is just a draft PR that I’m still working on (I’ve marked it with the WIP tag) - so some things like tests, deployment, etc., are still missing. Of course, I’ll take all your comments into account and let you know once this PR is ready for review! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants