fix: non-blocking browser launch in Pi extension (Linux)#292
Merged
Conversation
execSync(xdg-open ...) blocks the Node.js event loop, preventing the HTTP server from responding to the browser's initial request on Linux desktops where xdg-open doesn't immediately exit. Closes #288 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. Reviewed the 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
spawn() reports missing-command failures asynchronously via an 'error'
event. Without a listener, a bad PLANNOTATOR_BROWSER or missing
xdg-open crashes the Pi process. Add child.once("error", () => {})
to swallow it silently, matching the original execSync try/catch
behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execSync(xdg-open ...)withspawn(..., { detached: true, stdio: "ignore" }).unref()in the Pi extension'sopenBrowser()execSyncblocks the Node.js event loop, so the HTTP server can't respond to the browser's initial page request on Linux desktops wherexdg-opendoesn't immediately exit — causing a deadlockCloses #288
Test plan
openstill worksPLANNOTATOR_BROWSERoverride🤖 Generated with Claude Code