fix: don't ask agent to address feedback on LGTM approval#293
Merged
Conversation
When the reviewer approves with no annotations, send a neutral "Code review completed — no changes requested." message instead of the contradictory "LGTM" + "Please address this feedback." Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The previous fix inferred LGTM from an empty annotations array, but VS Code editor annotations are carried in feedbackMarkdown without populating the annotations array — causing real review comments to be misclassified as approvals. Thread an explicit `approved` boolean from the UI through the review server to all three integrations. Closes #284 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When the reviewer submits actual feedback, append "The reviewer has identified issues above. You must address all of them." so the agent treats annotations with urgency rather than soft-acknowledging them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
backnotprop
added a commit
that referenced
this pull request
Mar 18, 2026
The plugin's plannotator-review.md was updated in #293 to handle LGTM approvals but the install scripts still had the old wording. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
backnotprop
added a commit
that referenced
this pull request
Mar 18, 2026
* docs: add /plannotator-last to READMEs and marketing docs * feat: add /plannotator-last to install scripts * fix: sync review command wording in install scripts with plugin The plugin's plannotator-review.md was updated in #293 to handle LGTM approvals but the install scripts still had the old wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approvedboolean from the review UI through the server to all three integrations (Claude Code, OpenCode, Pi), replacing theannotations.lengthheuristic which misclassified VS Code editor-only annotations as approvalsCloses #284
Test plan
/plannotator-review→ approve with no annotations → agent should NOT be told to address feedback/plannotator-review→ add annotations and send feedback → agent should see feedback + "must address all of them"/plannotator-review→ VS Code editor annotations only, send feedback → agent should see feedback, NOT "no changes requested"🤖 Generated with Claude Code