fix: annotate-last fails on Windows with non-ASCII paths#340
Merged
Conversation
Claude Code replaces all non-[a-zA-Z0-9-] characters with dashes when deriving project slugs, but we only replaced forward slashes. This broke annotate-last on Windows and with non-ASCII (e.g. Cyrillic) paths. Also adds a case-insensitive fallback for directory lookup to handle Windows drive letter casing differences (C: vs c:). Closes #339 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
Testing on WindowsBuild from source (this PR)# 1. Clone and checkout the branch
git clone https://github.com/backnotprop/plannotator.git
cd plannotator
git checkout fix/last-windows
# 2. Install deps and build the HTML assets
bun install
bun run build:hook
# 3. Compile the binary
bun build apps/hook/server/index.ts --compile --outfile plannotator.exe
# 4. Put it on PATH (or note the full path for step 5)
move plannotator.exe %USERPROFILE%\.local\bin\plannotator.exeUse the local build instead of the marketplace installOption A — claude --plugin-dir ./apps/hookOption B — Replace the compiled binary the marketplace plugin points to: # Find where the current binary lives
where plannotator
# Replace it with the one you just built
copy /Y plannotator.exe <path-from-above>What to test
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
projectSlugFromCwdregex with Claude Code's actual normalization:[^a-zA-Z0-9-]→-(was only replacing/)C:vsc:)Closes #339
Test plan
/plannotator-lastbun test apps/hook/server/session-log.test.tspasses (32/32)