Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serviceMonitor port is a string not integer #258

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

ChrisJBurns
Copy link
Contributor

@ChrisJBurns ChrisJBurns commented Mar 29, 2025

Failing to pass kubeconform checks internally

Description of the change

  • forces port to be a string. before this change kubeconform failed with the following error:
stdin - ServiceMonitor backstage is invalid: problem validating schema. Check JSON formatting: jsonschema: '/spec/endpoints/0/port' does not validate with https://artifactory.ci.corp.tanium.com/artifactory/github/datreeio/CRDs-catalog/raw/main/monitoring.coreos.com/servicemonitor_v1.json#/properties/spec/properties/endpoints/items/properties/port/type: expected string, but got number
  • splits test and lint steps due to confusion in actions showing both as "Lint Charts".

Existing or Associated Issue(s)

Additional Information

https://github.com/yannh/kubeconform

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@ChrisJBurns ChrisJBurns requested a review from a team as a code owner March 29, 2025 13:28
@ChrisJBurns
Copy link
Contributor Author

ChrisJBurns commented Mar 29, 2025

@tumido @vinzscam @sabre1041

Just realised I only have reviewer privileges and not maintainer privileges 😄 so let me know if looks good so we can merge. This should also resolve what #241 aims to complete, but we haven't heard back from the author of the PR and it seems like a couple of people are keen for this fix.

@ChrisJBurns ChrisJBurns force-pushed the fix-servicemonitor-port-type branch from 1fc01c7 to 64e5a76 Compare March 29, 2025 14:12
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisJBurns ChrisJBurns merged commit cb7f0d4 into main Mar 31, 2025
3 checks passed
@ChrisJBurns ChrisJBurns deleted the fix-servicemonitor-port-type branch March 31, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants