Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references/files for RHDH from ACS plugin #3457

Merged
merged 8 commits into from
Mar 29, 2025

Conversation

maknop
Copy link
Contributor

@maknop maknop commented Mar 24, 2025

Hey, I just made a Pull Request!

Updating instructions for installing as a RHDH dynamic plugin and removing dist-scalprum from files in package.json.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@maknop maknop requested a review from a team as a code owner March 24, 2025 19:00
@maknop maknop requested a review from vinzscam March 24, 2025 19:00
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Mar 24, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-acs workspaces/acs/plugins/acs patch v0.0.2

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@maknop maknop force-pushed the fix_dynamic_plugin branch from ddd0a59 to 8c3eb67 Compare March 24, 2025 19:50
Signed-off-by: Matt Knop <[email protected]>
Copy link
Collaborator

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not appropriate for this repository - will sync with @maknop offline

@maknop maknop force-pushed the fix_dynamic_plugin branch from 7676cf7 to 5c59530 Compare March 28, 2025 19:25
@maknop maknop changed the title Fix dynamic plugin Remove references/files for RHDH from ACS plugin Mar 28, 2025
@BethGriggs BethGriggs dismissed their stale review March 28, 2025 19:43

Concerns addressed

@maknop maknop force-pushed the fix_dynamic_plugin branch from 12dae24 to 80a81e8 Compare March 28, 2025 19:57
maknop added 3 commits March 28, 2025 13:58
Signed-off-by: Matt Knop <[email protected]>
Signed-off-by: Matt Knop <[email protected]>
Signed-off-by: Matt Knop <[email protected]>
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BethGriggs BethGriggs merged commit 7eb2266 into backstage:main Mar 29, 2025
12 checks passed
@maknop
Copy link
Contributor Author

maknop commented Mar 29, 2025

Thank you, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants