Make FactRetrieverContext generic to support context extension #3646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Previously, the Tech Insights plugin only supported a fixed set of services in the FactRetrieverContext. This change enables plugin consumers to pass additional custom services into their FactRetriever implementations without modifying the core plugin code, improving extensibility while preserving the plugin's API contract.
FactRetrieverContextto accept a generic extension typeFactRetrieverinterface generic to work with extended context typesExample
Alternative
We wrap the creation of the FactRetriever with a factory function that takes our internal
serviceRefs.✔️ Checklist
Signed-off-byline in the message. (more info)