Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workspaces/gocd/.changeset/unlucky-ants-cover.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@backstage-community/plugin-gocd': patch
---

Replaces global JSX reference with React.JSX import
3 changes: 2 additions & 1 deletion workspaces/gocd/bcp.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"autoVersionBump": true,
"knipReports": false
"knipReports": false,
"listDeprecations": true
}
3 changes: 2 additions & 1 deletion workspaces/gocd/plugins/gocd/report.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@

import { BackstagePlugin } from '@backstage/core-plugin-api';
import { Entity } from '@backstage/catalog-model';
import { JSX as JSX_2 } from 'react';

// @public
export const EntityGoCdContent: () => JSX.Element;
export const EntityGoCdContent: () => JSX_2.Element;

// @public
export const GOCD_PIPELINES_ANNOTATION = 'gocd.org/pipelines';
Expand Down
4 changes: 2 additions & 2 deletions workspaces/gocd/plugins/gocd/src/api/gocdApi.client.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
* limitations under the License.
*/

import { setupRequestMockHandlers } from '@backstage/test-utils';
import { registerMswTestHooks } from '@backstage/test-utils';
import { GoCdClientApi } from './gocdApi.client';
import { HttpResponse, http } from 'msw';
import { setupServer } from 'msw/node';
import { PipelineHistory } from './gocdApi.model';

describe('GoCdClientApi', () => {
const server = setupServer();
setupRequestMockHandlers(server);
registerMswTestHooks(server);

it('makes requests through the proxy, using the provided fetch api', async () => {
const response: PipelineHistory = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { useState } from 'react';
import { useState, JSX } from 'react';
import { Entity } from '@backstage/catalog-model';
import {
useEntity,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { JSX } from 'react';
import { groupBy, mean } from 'lodash';
import {
PipelineHistory,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { useState } from 'react';

import * as React from 'react';
import { useState, JSX } from 'react';
import { Entity, getEntitySourceLocation } from '@backstage/catalog-model';
import { useEntity } from '@backstage/plugin-catalog-react';
import Alert from '@material-ui/lab/Alert';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { JSX } from 'react';
import FormControl from '@material-ui/core/FormControl';
import InputLabel from '@material-ui/core/InputLabel';
import MenuItem from '@material-ui/core/MenuItem';
import Select from '@material-ui/core/Select';
import { createStyles, makeStyles, Theme } from '@material-ui/core/styles';
import * as React from 'react';

export type Item = {
label: string;
Expand Down