Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workspaces/newrelic/.changeset/famous-terms-jog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@backstage-community/plugin-newrelic-dashboard': minor
---

Removes all existing deprecation notices. If you are still using `DashboardSnapshotComponent`, this will be a breaking change.
3 changes: 2 additions & 1 deletion workspaces/newrelic/bcp.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"autoVersionBump": true,
"knipReports": false
"knipReports": false,
"listDeprecations": true
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@ export const DashboardSnapshot: (props: {
permalink: string;
}) => JSX_2.Element;

// @public @deprecated
export const DashboardSnapshotComponent: (props: {
guid: string;
name: string;
permalink: string;
}) => JSX_2.Element;

// @public
export const DashboardSnapshotList: (props: { guid: string }) => JSX_2.Element;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

import { NewRelicDashboard } from './NewRelicDashboard';
import { MockStorageApi, TestApiProvider } from '@backstage/test-utils';
import { mockApis, TestApiProvider } from '@backstage/test-utils';
import { EntityProvider } from '@backstage/plugin-catalog-react';
import { newRelicDashboardApiRef } from '../../api';
import { NEWRELIC_GUID_ANNOTATION } from '../../constants';
Expand Down Expand Up @@ -115,7 +115,7 @@ export const NewRelicDashboardWithSnapshots = () => (
<TestApiProvider
apis={[
[newRelicDashboardApiRef, newRelicApiMockFull],
[storageApiRef, MockStorageApi.create()],
[storageApiRef, mockApis.storage()],
]}
>
<EntityProvider entity={entity}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,5 @@ export {
EntityNewRelicDashboardContent,
DashboardSnapshot,
DashboardSnapshotList,
DashboardSnapshotComponent,
} from './plugin';
export { isNewRelicDashboardAvailable } from './Router';
10 changes: 0 additions & 10 deletions workspaces/newrelic/plugins/newrelic-dashboard/src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,6 @@ export const DashboardSnapshot = newRelicDashboardPlugin.provide(
}),
);

/**
* Render dashboard snapshots from Newrelic in backstage. Use dashboards which have the tag `isDashboardPage: true`
*
* @deprecated
* Use DashboardSnapshot export name instead
*
* @public
*/
export const DashboardSnapshotComponent = DashboardSnapshot;

/**
* Render a dashboard snapshots list from Newrelic in backstage. Use dashboards which have the tag `isDashboardPage: true`
*
Expand Down
4 changes: 2 additions & 2 deletions workspaces/newrelic/plugins/newrelic/src/api/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { NewRelicApplication, NewRelicClient } from '.';
import { DiscoveryApi } from '@backstage/core-plugin-api';
import { rest } from 'msw';
import { setupServer } from 'msw/node';
import { MockFetchApi, setupRequestMockHandlers } from '@backstage/test-utils';
import { MockFetchApi, registerMswTestHooks } from '@backstage/test-utils';

const mockedDiscoveryApi: DiscoveryApi = {
getBaseUrl: async () => 'https://test.test',
Expand All @@ -30,7 +30,7 @@ beforeEach(() => {

describe('NewRelicClient', () => {
const server = setupServer();
setupRequestMockHandlers(server);
registerMswTestHooks(server);

beforeEach(() => {
server.resetHandlers();
Expand Down