tech-insights: ability to add filters on the checks #6697
Conversation
backstage-service
added
the
workspace/tech-insights
Changed Packages
|
surajnarwade
changed the title
surajnarwade
force-pushed
the
feat-checks-filter
branch
from
816f4b0 to
cf031e1
Compare
Signed-off-by: surajnarwade <[email protected]> Signed-off-by: surajnarwade <[email protected]>
Signed-off-by: surajnarwade <[email protected]> Signed-off-by: surajnarwade <[email protected]>
surajnarwade
force-pushed
the
feat-checks-filter
branch
from
cf031e1 to
d16ac69
Compare
surajnarwade
requested review from
a team,
Xantier and
punkle
as code owners
Signed-off-by: surajnarwade <[email protected]>
Signed-off-by: surajnarwade <[email protected]>
Signed-off-by: surajnarwade <[email protected]>
Signed-off-by: surajnarwade <[email protected]>
| deps: { | ||
| config: coreServices.rootConfig, | ||
| logger: coreServices.logger, | ||
| discovery: coreServices.discovery, | ||
| techInsights: techInsightsFactCheckerFactoryExtensionPoint, | ||
| }, | ||
| async init({ config, logger, techInsights }) { | ||
| async init({ config, logger, discovery, techInsights }) { | ||
| const catalogClient = new CatalogClient({ discoveryApi: discovery }); | ||
| const factory = JsonRulesEngineFactCheckerFactory.fromConfig(config, { | ||
| logger, | ||
| catalogApi: catalogClient, |
There was a problem hiding this comment.
A better route is having the module define catalog as a dependency with catalogServiceRef from @backstage/plugin-catalog-node. This is the newer way of communicating with the catalog as it includes auth support. In this scenario, I think passing { credentials: await this.auth.getOwnServiceCredentials() } as the second argument to the catalog api calls would suffice.
deps: {
config: coreServices.rootConfig,
logger: coreServices.logger,
- discovery: coreServices.discovery,
+ catalog: catalogServiceRef,
+ auth: coreServices.auth,
techInsights: techInsightsFactCheckerFactoryExtensionPoint,
}wdyt?
There was a problem hiding this comment.
I thought it's discouraged: https://backstage.io/docs/features/software-catalog/faq/#can-i-call-the-catalog-itself-from-inside-a-processor--provider 🤔
There was a problem hiding this comment.
That is referring to the ingestion and processing of entities in the catalog, known as EntityProvider and EntityProcessor. This factory class is neither a catalog provider or processor.
There was a problem hiding this comment.
ah okay, now it make sense. sorry I misunderstood earlier. I now found the similar references:
I will update my code accordingly, thank you for the review.
Signed-off-by: surajnarwade <[email protected]>
3 participants
This PR solves this issue: #4259
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-byline in the message. (more info)