feat(): Make tooltip and reference icon optional #7280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gijs Faessen <[email protected]>
Signed-off-by: Gijs Faessen <[email protected]>
faeshaas
requested review from
a team,
Xantier,
kurtaking,
maicaballangan and
punkle
as code owners
backstage-service
added
the
workspace/tech-insights
Contributor
Changed Packages
|
Signed-off-by: Gijs Faessen <[email protected]>
Signed-off-by: Gijs Faessen <[email protected]>
Member
|
@maicaballangan, leaving this one for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
In the current implementation of the maturity plugin it always shows a reference icon and tooltip for a check on the EntityMaturityScorecardContent. Even if a check doesn't have a link configured. This causes confusion so I made this Tooltip and MenuBookIcon optional so it only shows when a link is configured.
Here is an example how it looks like now when no link is configured for a check:
✔️ Checklist
Signed-off-byline in the message. (more info)