announcements: rewrite <OnBehalfOf /> with @backstage/ui select and include value in announcements table
#7288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backstage-service
added
the
workspace/announcements
Contributor
Changed Packages
|
kurtaking
changed the title
<OnBehalfOf /> with @backstage/ui select and include value in announcements table
This was referenced Jan 28, 2026
Signed-off-by: Kurt King <[email protected]>
kurtaking
force-pushed
the
announcements/on-behalf-of-rewrite
branch
from
bdd91f9 to
8d5a481
Compare
kurtaking
requested review from
04kash and
Copilot
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the "On Behalf Of" form component to use @backstage/ui components instead of Material-UI, and enhances the announcements table to display on behalf of information alongside the publisher.
Changes:
- Migrated
OnBehalfTeamDropdownfrom MUIAutocompleteto@backstage/uiSelectcomponent - Updated announcements table to show "on behalf of [group]" text when the field is populated
- Added comprehensive test coverage for the new on behalf of display functionality
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
AnnouncementsTable.tsx |
Added conditional rendering of "on behalf of" information in the publisher column when a valid entity reference exists |
AnnouncementsTable.test.tsx |
Added three new test cases covering display behavior with valid, missing, and invalid on_behalf_of values; updated test setup to use shared mock instance |
OnBehalfTeamDropdown.tsx |
Replaced MUI Autocomplete with Backstage UI Select component, simplified option rendering to use label/value pattern |
OnBehalfTeamDropdown.test.tsx |
Updated test expectations to match new Select component behavior where display names appear in both trigger and options |
.changeset/curly-zebras-agree.md |
Added changeset documenting the UI component migration and table display enhancement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...uncements/src/alpha/components/admin/announcements/AnnouncementForm/OnBehalfTeamDropdown.tsx
Show resolved
Hide resolved
...ements/plugins/announcements/src/alpha/components/admin/announcements/AnnouncementsTable.tsx
Outdated
Show resolved
Hide resolved
...ements/plugins/announcements/src/alpha/components/admin/announcements/AnnouncementsTable.tsx
Outdated
Show resolved
Hide resolved
…into announcements/on-behalf-of-rewrite
Signed-off-by: Kurt King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Refactors the "On Behalf Of" form component to use
@backstage/uicomponents.With this, I got the idea to update the announcements table to render "on behalf of
[group]" when value is present. It's a decent way of adding this information back to the table without an additional column (similar to status indicator).✔️ Checklist
Signed-off-byline in the message. (more info)