Skip to content

Bitpacked nucleotides#69

Open
mtrsl wants to merge 8 commits into
mainfrom
bitpacked
Open

Bitpacked nucleotides#69
mtrsl wants to merge 8 commits into
mainfrom
bitpacked

Conversation

@mtrsl
Copy link
Copy Markdown
Collaborator

@mtrsl mtrsl commented Apr 20, 2026

(I still need to move the containment stubs into another branch/just remove for now)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 98.12500% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.45%. Comparing base (256e15e) to head (3d5d2b6).

Files with missing lines Patch % Lines
src/hashing/nthash_iterator.rs 98.11% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   91.36%   92.45%   +1.08%     
==========================================
  Files          17       17              
  Lines        2675     2914     +239     
==========================================
+ Hits         2444     2694     +250     
+ Misses        231      220      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnlees
Copy link
Copy Markdown
Member

johnlees commented May 8, 2026

@vrbouza I think this is working now, but we did everything outside of the WASM code. Can you give us some help/guidance on what we'd need to change to make the same changes WASM comaptible? Is it just making the same updates in the add_dna_seq() and new() WASM functions in ntHashIterator do you think?

@vrbouza
Copy link
Copy Markdown
Collaborator

vrbouza commented May 8, 2026

@vrbouza I think this is working now, but we did everything outside of the WASM code. Can you give us some help/guidance on what we'd need to change to make the same changes WASM comaptible? Is it just making the same updates in the add_dna_seq() and new() WASM functions in ntHashIterator do you think?

Yes, I think so (quickly reviewed the updates to nthashiterator and the rest). Also, in inverted.rs you'll need to update the other nthashiterator, though that in particular (and potentially any other calls to nthashiterator) should naturally appear once you update the wasm-gated nthashiterator constructor and add_dna_seq() and try compiling with cargo build --release --target wasm32-unknown-unknown, but I don't see any other place where it'd be needed to change now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants