Skip to content

Conversation

@jNullj
Copy link
Member

@jNullj jNullj commented Sep 23, 2025

Some work that needs to be done pointed at this comment
Links to a list of breaking changes for: v7, v8

@jNullj jNullj added the dependencies Related to dependency updates label Sep 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against fa90feb

… context

due to breaking changes in pathToRegexp that removed regex support
@jNullj
Copy link
Member Author

jNullj commented Sep 24, 2025

A few new insights

  1. There is simply too much regex, every pattern's enum is not supports.
  2. Rewriting all routes is lots of work.
  3. I looked at a potential replacement regexparam, seems to not be easy to work with as it also does not support regex operations we need.
  4. Another alternative url-pattern is unmaintained for 9 years.
  5. I looked into how this will effect our move to express as we might be able to use some of it's functionality, and surprised to learn that express uses path-to-regexp.

some alternatives to pattern enum might be:

  1. Accepting any string as route and validating the enum in service.
  2. Extracting pattern options at prepareRoute and recreate the regex with the options (also should effect getEnum function).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related to dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant