-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
feat(comfyui): Add ComfyUI Registry service, tests, fixture and docs #11489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
@PyvesB Hii, could you review my code. |
|
Hello @neverbiasu 👋🏻 What is the rationale for adding a cache layer for this badge? We typically cache at the CDN layer, which has the advantage of being shared across all running Shields.io instances and completely bypasses any processing. |
|
Hii, @PyvesB. Thx for your suggestions. I will try to use it. |
|
I'd suggest following our tutorial and generally speaking keeping things as simple as possible: https://github.com/badges/shields/blob/master/doc/TUTORIAL.md By the way, do you have any information on the API's rate limits? |
|
@PyvesB Thx for the suggestions, I have rewrite in the format mentioned in TUTOTIAL.md. I didn't know the API's rate limits but I can ask the backend dev of ComfyUI and answer it later. |
Summary
Add ComfyUI Registry badges (downloads, version, stars) with a resilient fetcher, tests, fixture and docs.
What this PR does
Testing (local)
NODE_CONFIG_ENV=test npx mocha comfyui-registry.spec.js --timeout 5000
-> 3 passing locally
Notes for reviewers
Changelog entry