Skip to content

Conversation

@sorki
Copy link

@sorki sorki commented Nov 18, 2025

This reverts commit 04f4fbd.

The service is fully functional again and updated regularly, restoring the removal from #10618

@github-actions
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @sorki!

Generated by 🚫 dangerJS against 77f9d64

@PyvesB
Copy link
Member

PyvesB commented Nov 18, 2025

Hello @sorki 👋🏻

The service is fully functional again and updated regularly

Do you have more details on this?

@sorki
Copy link
Author

sorki commented Nov 18, 2025

Hello @sorki 👋🏻

The service is fully functional again and updated regularly

Do you have more details on this?

Hey @PyvesB,

there used to be a deprecation on the front page notice for couple of months which is no longer the case and you can also see Database last updated on the bottom reflecting daily updates.

@PyvesB
Copy link
Member

PyvesB commented Nov 19, 2025

I'm little hesitant to be honest. The front page redirects to a GitHub repository that has had no activity in over 18 months, and a package where all the badges are broken. We generally only integrate with upstream services that are actively maintained and supported, which does not seem to be the case here. I'm curious to hear what @jNullj has to say as he was the one who originally deprecated this service.

@jNullj
Copy link
Member

jNullj commented Nov 19, 2025

review:
In #10618 I removed the service as it had no one to host it the service and was considered sun-setting. That was in october 2024.
It seems that a user started hosting on his own around the beginning of 2025 and got the original domain.
Considering the service is up for around a year I think we can restore it, worst case we start getting failing live tests we can take it down.
I think we will not lose focus on other project goals over this as it doesn't change often and required code already exist and is field tested, as this should be a revert to what we used to have.

@jNullj jNullj added the service-badge New or updated service badge label Nov 19, 2025
Copy link
Member

@jNullj jNullj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorki Could you fix the test for the issue mentioned at #10618 (comment) ?
We assume the package is not out of date if we don't get a valid outdated message, this is not very robust.
We might look for Database last updated at license endpoint or some other solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-badge New or updated service badge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants