-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Revert "Deprecate HackageDeps service (#10618)" #11511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 04f4fbd.
|
Hello @sorki 👋🏻
Do you have more details on this? |
Hey @PyvesB, there used to be a deprecation on the front page notice for couple of months which is no longer the case and you can also see |
|
I'm little hesitant to be honest. The front page redirects to a GitHub repository that has had no activity in over 18 months, and a package where all the badges are broken. We generally only integrate with upstream services that are actively maintained and supported, which does not seem to be the case here. I'm curious to hear what @jNullj has to say as he was the one who originally deprecated this service. |
|
review: |
jNullj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sorki Could you fix the test for the issue mentioned at #10618 (comment) ?
We assume the package is not out of date if we don't get a valid outdated message, this is not very robust.
We might look for Database last updated at license endpoint or some other solution.
This reverts commit 04f4fbd.
The service is fully functional again and updated regularly, restoring the removal from #10618