Fix [PubDownloads] test - #12101
Merged
Merged
Conversation
The monthly download count for `analysis_options` has grown past 1000, which is the top threshold in `downloadCount` (`floorCount(downloads, 10, 100, 1000)`), so the badge now renders `brightgreen` rather than `green`. Update the expected color to match.
hatefrad
force-pushed
the
fix-pub-downloads-test
branch
from
August 6, 2026 22:38
d92129e to
d04889e
Compare
Contributor
PyvesB
added
the
keep-service-tests-green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PubDownloadslive test has been failing in the daily test runs.The monthly download count for
analysis_optionshas grown past 1000, which is the top threshold indownloadCount:So the badge now renders
brightgreenwhile the test still expectedgreen. This updates the expected color to match. Asbrightgreenis the top bucket, this shouldn't drift again.Verified locally with
npm run test:services -- --only=pub(13 passing).